Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textfield improvements #81

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

miozune
Copy link
Collaborator

@miozune miozune commented Sep 11, 2024

See individual commit for more info.

Handler test prevents invalid chars from removing textbox
This is the same behavior as of MUI1. Also Windows uses 530 ms by default.
The implementation is somewhat dirty, but I can't think of better way.
I renamed constant E to NAPIER, as it clashes with E notation. I don't think someone will use this anyway.
Printing to log might make people think it's bug in code.
This feature can be used for indicator of what's wrong with the use input.
This also stops function construction from failing silently.
I believe this is better than silently dividing by 1.
It's not game-breaking fatal error anyway.
Former defaultValue is gone, because 1. It's set by onInit 2. It's better to restore the last value rather than something supposed to be default
TextFieldWidget -> OneLineTextField
StringTextFieldWidget -> TextFieldWidget
This reverts commit 8e00147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants